Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tailwind: PanelMenu: Documentation Pointing to Incorrect TRANSITION #5198

Closed
gcko opened this issue Oct 31, 2023 · 0 comments · Fixed by #5199
Closed

Tailwind: PanelMenu: Documentation Pointing to Incorrect TRANSITION #5198

gcko opened this issue Oct 31, 2023 · 0 comments · Fixed by #5199
Assignees
Labels
Component: Documentation Issue or pull request is related to Documentation
Milestone

Comments

@gcko
Copy link
Contributor

gcko commented Oct 31, 2023

Describe the bug

The Documentation is pointing an unused TRANSITIONS key, and fails to mention toggleable which is used in the subsequent Tailwind configuration.

Reproducer

No response

PrimeReact version

10.0.2

React version

18.x

Language

TypeScript

Build / Runtime

Next.js

Browser(s)

No response

Steps to reproduce the behavior

  1. Go to https://primereact.org/panelmenu/#tailwind
  2. Note the TRANSITIONS Listed and the TRANSITIONS key used are not the same:
// lists `overlay`
const TRANSITIONS = {
    overlay: {
        enterFromClass: 'opacity-0 scale-75',
        enterActiveClass: 'transition-transform transition-opacity duration-150 ease-in',
        leaveActiveClass: 'transition-opacity duration-150 ease-linear',
        leaveToClass: 'opacity-0'
    }
};
// Tailwind styles
const Tailwind = {
    panelMenu: {
        // shortened for brevity
        transition: TRANSITIONS.toggleable
    }
}

Expected behavior

The TRANSITIONS listed should be toggleable

@gcko gcko added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 31, 2023
@melloware melloware added Component: Documentation Issue or pull request is related to Documentation and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 31, 2023
@melloware melloware added this to the 10.0.8 milestone Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation Issue or pull request is related to Documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants