Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTable: passthrough styling is ignored #5131

Closed
dmit4git opened this issue Oct 21, 2023 · 2 comments · Fixed by #5133
Closed

DataTable: passthrough styling is ignored #5131

dmit4git opened this issue Oct 21, 2023 · 2 comments · Fixed by #5133
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.0.6

Comments

@dmit4git
Copy link

Describe the bug

Styling provided as passthrough to DataTable and Column is overridden by theme styling.

Screencast from 10-21-2023 01_45_09 AM

Reproducer

https://codesandbox.io/s/primereact-demo-forked-szt2vf

PrimeReact version

10.0.x

React version

18.x

Language

ES6

Build / Runtime

Create React App (CRA)

Browser(s)

Chrome, Firefox

Steps to reproduce the behavior

  1. Change version of primereact dependency to 9.6.3 in package.json
  2. Observe that passthrough styles are applied
  3. Change it back to 10.0.x
  4. See how passthrough styles are ignored

Expected behavior

Passthrough styles should have precedence over theme styles.
@dmit4git dmit4git added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 21, 2023
@dmit4git
Copy link
Author

This may be the same bug as #5125.

@melloware
Copy link
Member

Yep I think it is. I have been looking at this trying to figure it out.

@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 21, 2023
@melloware melloware mentioned this issue Oct 21, 2023
Merged
@melloware melloware self-assigned this Oct 21, 2023
@melloware melloware added this to the 10.0.6 milestone Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.0.6
Development

Successfully merging a pull request may close this issue.

Fix #5125: Defensive handling of finding passthrough prop melloware/primereact
2 participants
@melloware @dmit4git