Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name prop to Chips #483

Closed
robbevwinckel opened this issue Jul 3, 2018 · 1 comment
Closed

Add name prop to Chips #483

robbevwinckel opened this issue Jul 3, 2018 · 1 comment
Assignees
Labels
Type: New Feature Issue contains a new feature or new component request
Milestone

Comments

@robbevwinckel
Copy link

There is no guarantee in receiving an immediate response in GitHub Issue Tracker, If you'd like to secure our response, you may consider PrimeReact PRO Support where support is provided within 4 business hours

I'm submitting a ... (check one with "x")

[ ] bug report
[x] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

It would be nice if you can add a name property to the Chips component so we can access it (on the input element).

Second request is to make the return types of the value with onAdd and onRemove the same. Right now when adding it returns a string, while removing it returns an array with the value in.

So either both as a string or both as an array of a string would be helpful.

@cagataycivici cagataycivici self-assigned this Jul 4, 2018
@cagataycivici cagataycivici added the Type: New Feature Issue contains a new feature or new component request label Jul 4, 2018
@cagataycivici cagataycivici added this to the 2.0.0 milestone Jul 4, 2018
@cagataycivici cagataycivici changed the title Feature Request - Chips: add name property + make return value of onAdd/onRemove same type Chips: add name property + make return value of onAdd/onRemove same type Jul 4, 2018
@cagataycivici
Copy link
Member

onAdd and onRemove both pass the added/removed item as a string so I could not see that, but added name.

@cagataycivici cagataycivici changed the title Chips: add name property + make return value of onAdd/onRemove same type Add name prop to Chips Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Development

No branches or pull requests

2 participants