MultiSelect: on clicking inside checkbox to uncheck dropdown closes and maxLength and max not working

[abdulbasit159]

Describe the bug

on clicking inside the checkbox to uncheck selected value dropdown closes and maxLength and max not working

Reproducer

No response

PrimeReact version

9.6.0

React version

18.x

Language

TypeScript

Build / Runtime

Next.js

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

[1p0d]

Got the same problem with the dropdown getting closed on unchecking a checkbox directly in a TreeSelect with selectionMode checkbox. The dropdown does not close if you select an element by not clicking directly on the checkbox. The expected behavior would be that the dropdown does not close on clicking the checkbox since users probably want to select further things in a multi (tree) select. This expected behavior can be found back in v8.7

[melloware]

I need Code Sandbox reproducers for all these issues to see them in action.

[melloware]

You can use this one to start with and edit it to show the bug: https://stackblitz.com/edit/react-duwxzn?file=src%2FApp.js

[1p0d]

You can use this one to start with and edit it to show the bug: https://stackblitz.com/edit/react-duwxzn?file=src%2FApp.js

The described behavior shows in your sandbox already. Unchecking an element by clicking on the checkmark closes the dropdown, clicking on an elements text does not. The latter is what I would expect when clicking on the checkbox as well.

Edit: Upon further inspection it seems that it is not the checkbox, but the check icon (svg element) inside it that gets the dropdown closed when clicking on it.

[melloware]

Yep I already fixed that in master both issues. SVG icons had an issue: #4662

if you check out master and run npm run install then npm run dev you can test it is fixed.

[jerlam06]

@melloware I can confirm that the issue is still there. Reproducible here: https://primereact.org/multiselect/
See: #4523

[melloware]

Yep see the milestone on this ticket says it's slated for 10.0.0

[jerlam06]

@jerlam06 Ups my bad. Thanks :)