Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to change rows per page (Paginator/DataTable) #449

Closed
robbevwinckel opened this issue Jun 20, 2018 · 2 comments
Closed

Unable to change rows per page (Paginator/DataTable) #449

robbevwinckel opened this issue Jun 20, 2018 · 2 comments
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@robbevwinckel
Copy link

There is no guarantee in receiving an immediate response in GitHub Issue Tracker, If you'd like to secure our response, you may consider PrimeReact PRO Support where support is provided within 4 business hours

I'm submitting a ...

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Unable to change row per page in Paginator on DataTable.
Example on the PrimeReact documentation stopped working as well https://www.primefaces.org/primereact/#/datatable/paginator

The reason is perhaps the latest change https://github.com/primefaces/primereact/commit/0fa659e56b2c20b6689940cb7dda772c685a427d

@mertsincan mertsincan self-assigned this Jun 26, 2018
@mertsincan mertsincan added the Type: Bug Issue contains a defect related to a specific component. label Jun 26, 2018
@mertsincan mertsincan added this to the 1.6.3 milestone Jun 26, 2018
@cagataycivici cagataycivici reopened this Jun 27, 2018
@cagataycivici
Copy link
Member

Reopen as we need to make changes to Table to make it usable as controlled/uncontrolled due to changes in React 16.4.

@cagataycivici
Copy link
Member

Resolved now as paginator can be used controlled/uncontrolled, with full support for recent changes on 16.4. Fully backward compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

No branches or pull requests

3 participants