Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global: Click events not working on iOS #3949

Open
melloware opened this issue Jan 12, 2023 · 1 comment
Open

Global: Click events not working on iOS #3949

melloware opened this issue Jan 12, 2023 · 1 comment
Labels
Device: Mobile Issue or pull request is *only* related to Mobile device Status: Discussion Issue or pull request needs to be discussed by Core Team

Comments

@melloware
Copy link
Member

melloware commented Jan 12, 2023

Describe the bug

Browse to any example on the showcase with Safari on IOS15*+

Clicking on buttons has no effect. It seems like Click events on anything are not working.

https://betterprogramming.pub/pointer-events-with-react-the-why-how-what-617a5b51dbb2

Reproducer

No response

PrimeReact version

8.7.3

React version

18.x

Language

TypeScript

Build / Runtime

Next.js

Browser(s)

iOS 16.2 using Safari

Steps to reproduce the behavior

Go to showcase on an iOS 16.2 device and try and click any button on the Messages or Toast demo pages.

Expected behavior

Click events work

@melloware melloware added the Device: Mobile Issue or pull request is *only* related to Mobile device label Jan 12, 2023
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 12, 2023
@melloware
Copy link
Member Author

melloware commented Jan 12, 2023

It looks like all click and mouse events in react should be switched to Pointer Events...

Pointer events allow handling mouse, touch and pen events simultaneously, with a single piece of code. Pointer events extend mouse events. We can replace mouse with pointer in event names and expect our code to continue working for mouse, with better support for other device types.

Docs: https://reactjs.org/blog/2018/05/23/react-v-16-4.html

https://betterprogramming.pub/pointer-events-with-react-the-why-how-what-617a5b51dbb2

@mertsincan mertsincan added the Status: Discussion Issue or pull request needs to be discussed by Core Team label Jan 12, 2023
@melloware melloware removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Device: Mobile Issue or pull request is *only* related to Mobile device Status: Discussion Issue or pull request needs to be discussed by Core Team
Projects
None yet
Development

No branches or pull requests

2 participants