Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfirmDialog: mismatch in new version #3063

Closed
MaxK4Code opened this issue Jul 15, 2022 · 2 comments
Closed

ConfirmDialog: mismatch in new version #3063

MaxK4Code opened this issue Jul 15, 2022 · 2 comments
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@MaxK4Code
Copy link

Describe the bug

Hey guys,

the types in ConfirmDialog.d.ts has mismatches with the export in ConfirmDialog.js.

The component returns a tuple of [show, hide]. The show-functions works but hide does not do anything.

In the documentation I cannot find anything about it.

Reproducer

https://codesandbox.io/s/primereact-test-forked-02vtpx

PrimeReact version

8.2.0

React version

17.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

all

Steps to reproduce the behavior

open reproducer sandbox and wait till timeout

Expected behavior

  1. hide should hide the dialog
  2. types should match with the export of the component
  3. documentation should show an example with show and hide functions
@MaxK4Code MaxK4Code added Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: Bug Issue contains a defect related to a specific component. labels Jul 15, 2022
@melloware
Copy link
Member

OK I can confirm the hide method is being called it just doesn't look like it actually does anything.

 OverlayService.emit('confirm-dialog', { visible: false });

@melloware melloware added 👍 confirmed and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jul 15, 2022
@melloware
Copy link
Member

I have assigned to Mert as I don't quite understand how this confirm dialog is wired up.

@mertsincan mertsincan added this to the 9.0.0 milestone Jul 15, 2022
@mertsincan mertsincan modified the milestones: 9.0.0, 8.3.0 Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

No branches or pull requests

3 participants