Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The SplitButton type declarations are missing the "show" and "hide" methods #2625

Closed
dchenk opened this issue Feb 3, 2022 · 1 comment · Fixed by #2626
Closed

The SplitButton type declarations are missing the "show" and "hide" methods #2625

dchenk opened this issue Feb 3, 2022 · 1 comment · Fixed by #2626
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@dchenk
Copy link
Contributor

dchenk commented Feb 3, 2022

I'm submitting a ...

[X] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Current behavior

The TypeScript declaration file for the SplitButton does not list "show" and "hide" as methods even though they are defined. This prevents programmatic opening/closing of the menu.

Expected behavior

The SplitButton should have the (already implemented) show and hide methods listed in the type declaration in the file components/lib/splitbutton/SplitButton.d.ts.

Please tell us about your environment:
N/A

  • React version:
    N/A

  • PrimeReact version:
    7.2.0

  • Browser:
    N/A

  • Language: [all | TypeScript X.X | ES6/7 | ES5]
    N/A

@melloware
Copy link
Member

Much appreciated for submitting the PR as well.

@yigitfindikli yigitfindikli added this to the 7.2.1 milestone Feb 10, 2022
@yigitfindikli yigitfindikli added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Feb 10, 2022
@yigitfindikli yigitfindikli added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants