Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable scrollable and responsive layout confusion #2479

Closed
VsevolodGolovanov opened this issue Nov 29, 2021 · 7 comments
Closed

DataTable scrollable and responsive layout confusion #2479

VsevolodGolovanov opened this issue Nov 29, 2021 · 7 comments
Assignees
Labels
Resolution: Duplicate Issue has already been reported or a pull request related to same issue has already been submitted

Comments

@VsevolodGolovanov
Copy link

VsevolodGolovanov commented Nov 29, 2021

https://www.primefaces.org/primereact/showcase/#/datatable says:

Note that Scrollable and/or Resizable tables do not support auto layout due to technical limitations.

But this is not the case since PR 7, right? Since scrollable is now implemented as a sticky header.

Set responsiveLayout to scroll to enabled this layout. Note that, when scroll mode is enabled table-layout automatically switches to auto from fixed as a result table widths are likely to differ and resizable columns are not supported.

Is that all responsiveLayout="scroll" does, just sets table-layout="auto" permanently? This doesn't seem "responsive". Why do this at all? A table can be scrolled regardless of its layout.

Scrollable tables use the scroll layout approach internally and do not require additional configuration.

So scrollable="true" implies responsiveLayout="scroll"? But why? Thankfully this doesn't seem to actually happen - a scrollable table remains table-layout="fixed", which is what I want.

  • PrimeReact version:
    7.0.1
@VsevolodGolovanov
Copy link
Author

VsevolodGolovanov commented Nov 29, 2021

Since scrollable is now implemented as a sticky header.

Which by the way leaves a looot of browsers behind: IE11 of course, and even Chrome <= 90: https://caniuse.com/css-sticky

@melloware
Copy link
Member

Just my two cents I am 100% OK with leaving IE11 for dead where it belongs :)

@VsevolodGolovanov
Copy link
Author

No programmer supports IE11 because he wants to :)

@melloware
Copy link
Member

No programmer supports IE11 because he wants to :)

100% the funniest thing I have heard today. You just made my day. 😄

@giovannispd
Copy link

this actually happen (7.2.1)!! it's impossible to have a datatable with scrollable="true" and responsiveLayout="stack" as it was before 7x

@giovannispd
Copy link

this datatable's upgrade with 7.x is terrific!!! breaks all my datatables!

@melloware melloware added the Component: Documentation Issue or pull request is related to Documentation label Apr 10, 2022
@melloware melloware added this to the 8.1.0 milestone May 5, 2022
@mertsincan mertsincan modified the milestones: 8.2.0, 9.0.0 Jul 6, 2022
@melloware
Copy link
Member

More info over at #3091

@melloware melloware removed this from the 9.0.0 milestone Jul 23, 2022
@melloware melloware added Resolution: Duplicate Issue has already been reported or a pull request related to same issue has already been submitted and removed Component: Documentation Issue or pull request is related to Documentation labels Jul 23, 2022
@melloware melloware assigned melloware and unassigned mertsincan Jan 4, 2023
@melloware melloware linked a pull request Jan 4, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Duplicate Issue has already been reported or a pull request related to same issue has already been submitted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants