Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add header, footer and magnification properties to Dock #2362

Closed
davidbejarcaceres opened this issue Oct 27, 2021 · 2 comments
Closed

Add header, footer and magnification properties to Dock #2362

davidbejarcaceres opened this issue Oct 27, 2021 · 2 comments
Assignees
Labels
Type: New Feature Issue contains a new feature or new component request
Milestone

Comments

@davidbejarcaceres
Copy link

I'm submitting a ...

[ ] bug report
[X] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Codesandbox Case (Bug Reports)
I have created a demo in CodeSandbox:

https://codesandbox.io/s/primereact-test-forked-wqr1f?file=/src/DockDemo.js

Current behavior
Now there is no option to move the Dock if we have content below the Dock, so can´t click elements below

Expected behavior
A button in the Dock, after click the button, the Dock should change position.

Dock Moving gif

Minimal reproduction of the problem with instructions
Try add the Dock to a Page, if you have elements behind/under the Dock, you wont be able to interact with them, only moving the Dock will allow it.

Please tell us about your environment:
React 16.+
Chrome: 95.***

  • React version:
    React 16.+

  • PrimeReact version:
    6.5

  • Language: [all | TypeScript X.X | ES6/7 | ES5]
    Javascript

@melloware
Copy link
Member

Why not submit this as a PR?

@mertsincan mertsincan changed the title Dock [Feature]"Dock" Add a button to move to other positions Add header, footer and magnification property to Dock Nov 3, 2021
@mertsincan mertsincan changed the title Add header, footer and magnification property to Dock Add header, footer and magnification properties to Dock Nov 3, 2021
@mertsincan mertsincan added the Type: New Feature Issue contains a new feature or new component request label Nov 3, 2021
@mertsincan mertsincan added this to the 7.0.0.Final milestone Nov 3, 2021
@mertsincan mertsincan self-assigned this Nov 3, 2021
@mertsincan
Copy link
Member

mertsincan commented Nov 3, 2021

Hi,

You can use;

<Dock position={currentPosition} header={<button onClick={() => setCurrentPosition(...)}>Test</button>} magnification={false} .../>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Development

No branches or pull requests

3 participants