Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] 6.5.1 Toast - ContentClassName prop should be optional #2247

Closed
jafin opened this issue Aug 18, 2021 · 1 comment
Closed

[BUG] 6.5.1 Toast - ContentClassName prop should be optional #2247

jafin opened this issue Aug 18, 2021 · 1 comment
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@jafin
Copy link
Contributor

jafin commented Aug 18, 2021

I'm submitting a ...

[x] bug report

Current behavior
A change in 6.5.1 made the property contentClassName mandatory. For other controls this is an optional property, it would be beneficial to be consistent.

Expected behavior
Should be optional and defaulted if requires a value. (similar to other controls)

For example, TabPanel defaults contentClassName to null and the property is optional on the interface

    static defaultProps = {
        header: null,
        headerTemplate: null,
        leftIcon: null,
        rightIcon: null,
        disabled: false,
        headerStyle: null,
        headerClassName: null,
        contentStyle: null,
        contentClassName: null
    }
export interface TabPanelProps {
    header?: React.ReactNode;
    headerTemplate?: TabPanelHeaderTemplateType;
    leftIcon?: string;
    rightIcon?: string;
    disabled?: boolean;
    headerStyle?: object;
    headerClassName?: string;
    contentStyle?: object;
    contentClassName?: string;
}
  • PrimeReact version:
    6.5.1
@mcandu mcandu closed this as completed in ef36a02 Aug 19, 2021
@mcandu mcandu added this to the 7.0.0 milestone Aug 19, 2021
@mcandu mcandu added the Type: Bug Issue contains a defect related to a specific component. label Aug 19, 2021
@mcandu mcandu self-assigned this Aug 19, 2021
@mcandu
Copy link
Contributor

mcandu commented Aug 19, 2021

Thank you for your feedback.

Best Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

No branches or pull requests

2 participants