Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable editor with 3rd party dropdown / overlay #2097

Closed
jc-1234 opened this issue Jun 8, 2021 · 3 comments · Fixed by #5373
Closed

DataTable editor with 3rd party dropdown / overlay #2097

jc-1234 opened this issue Jun 8, 2021 · 3 comments · Fixed by #5373
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@jc-1234
Copy link

jc-1234 commented Jun 8, 2021

There is no guarantee in receiving an immediate response in GitHub Issue Tracker, If you'd like to secure our response, you may consider PrimeReact PRO Support where support is provided within 4 business hours

I'm submitting a ... (check one with "x")

[ x ] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Codesandbox Case (Bug Reports)
https://codesandbox.io/s/quirky-hill-w9ek1?file=/src/demo/DataTableEditDemo.tsx

Current behavior
When editor is a 3rd party or custom dropdown / overlay, clicking inside the dropdown or overlay will close the editor and turn cell back to view only. However, using PrimeReact dropdown or overlay works fine.

Expected behavior
DataTable cell editor should support 3rd party or custom dropdown / overlay. Or allow a way for developers to prevent closing of cell editor when clicking inside a custom dropdown or overlay.

Minimal reproduction of the problem with instructions
https://codesandbox.io/s/quirky-hill-w9ek1?file=/src/demo/DataTableEditDemo.tsx

  1. Click on a cell in Date column
  2. Try to switch month in the drop down calendar via the top right > button in the calendar
  3. Drop down calendar closes right away and user can not switch months

Please tell us about your environment:
Windows 10, latest npm and node

  • React version:
    v17.x

  • PrimeReact version:
    v6.3.2

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
    Chrome

  • Language: [all | TypeScript X.X | ES6/7 | ES5]
    Typescript

@sdt-jchau
Copy link

any update on this? Will this be fixed ever so PrimeReact works with other React components?

@mcandu mcandu self-assigned this Dec 9, 2021
@mcandu mcandu added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Dec 9, 2021
@melloware
Copy link
Member

I think this is related to this: #2666

Anything clicked on that is not the target closes the editor as it thinks its "done"

@mcandu mcandu removed their assignment Jul 29, 2022
@habubey
Copy link
Contributor

habubey commented Oct 30, 2023

Issue tracker is used for defects only as part of our commitment to quality and continuous improvement in all areas. Enhancements are collected as valuable community feedback and managed internally so moving this enhancement ticket to our internal project management backlog.

@habubey habubey closed this as completed Oct 30, 2023
@melloware melloware self-assigned this Nov 22, 2023
@melloware melloware added this to the 10.2.0 milestone Nov 22, 2023
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants