Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TreeTable does not account for changes in scrollHeight #1850

Closed
jc-1234 opened this issue Mar 5, 2021 · 0 comments
Closed

TreeTable does not account for changes in scrollHeight #1850

jc-1234 opened this issue Mar 5, 2021 · 0 comments
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@jc-1234
Copy link

jc-1234 commented Mar 5, 2021

There is no guarantee in receiving an immediate response in GitHub Issue Tracker, If you'd like to secure our response, you may consider PrimeReact PRO Support where support is provided within 4 business hours

I'm submitting a ... (check one with "x")

[ x] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Current behavior
When scrollHeight is updated, TreeTable does not adjust to new scrollHeight value. This is because in TreeTableScrollableView, there's no handling of componentDidUpdate and recalling setScrollHeight based on scrollHeight prop change.

Expected behavior
When scrollHeight changes, TreeTable changes to account for new value.

Minimal reproduction of the problem with instructions

Please tell us about your environment:
Windows

  • React version:
    16.x

  • PrimeReact version:
    6.0.2

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
    Chrome, IE

  • Language: [all | TypeScript X.X | ES6/7 | ES5]
    Typescript

@mcandu mcandu self-assigned this Apr 15, 2021
@mcandu mcandu added this to the 6.2.2 milestone Apr 15, 2021
@mcandu mcandu added the Type: Bug Issue contains a defect related to a specific component. label Apr 15, 2021
@mcandu mcandu closed this as completed in 70ab3f6 Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

No branches or pull requests

2 participants