Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No typing for confirmPopup and confirmDialog #1765

Closed
TheAsda opened this issue Jan 21, 2021 · 3 comments
Closed

No typing for confirmPopup and confirmDialog #1765

TheAsda opened this issue Jan 21, 2021 · 3 comments
Assignees
@mertsincan
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
6.0.1

Comments

@TheAsda
Copy link

TheAsda commented Jan 21, 2021

Currently there is no typing for confirmPopup.
So typescript shows error if i want to use the function.

I'm submitting a ...

[x] bug report
[ ] feature request
[ ] support request

  • React version: 17.0.1

  • PrimeReact version: 6.0.0
@yosbelms
Copy link

The same is happening with confirmDialog

@dattebayorob
Copy link

Yeah

@voronp
Copy link

voronp commented Jan 25, 2021

also accept, reject callbacks not included in ConfirmPopupProps interface

@mertsincan mertsincan changed the title No typing for confirmPopup No typing for confirmPopup and confirmDialog Jan 27, 2021
@mertsincan mertsincan self-assigned this Jan 27, 2021
@mertsincan mertsincan added the Type: Bug Issue contains a defect related to a specific component. label Jan 27, 2021
@mertsincan mertsincan added this to the 6.0.1 milestone Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mertsincan mertsincan

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
6.0.1
Development

No branches or pull requests
5 participants
@mertsincan @yosbelms @voronp @TheAsda @dattebayorob