Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog dismissableMask didn't work if hide the close icon #1745

Closed
Shadorius opened this issue Jan 8, 2021 · 0 comments
Closed

Dialog dismissableMask didn't work if hide the close icon #1745

Shadorius opened this issue Jan 8, 2021 · 0 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@Shadorius
Copy link

I'm submitting this issue:
Dialog dismissableMask need "clausable" to true, else it didn't work!
Dialog will not be hide if you set to false "clausable", but doc didn't talk about it. The documentation says:
"clausable":"Adds a close icon to the header to hide the dialog."

I think it should hide the dialog when "dismissableMask" is true and user click out of the dialog with any value of "clausable".

[X] bug report
[ ] feature request
[ ] support request

Codesandbox Case (Bug Reports)

https://codesandbox.io/s/dialog-with-form-forked-k9ftr?fontsize=14&hidenavigation=1&theme=dark

Current behavior
The dialog will not be hide when user click out of the dialog.

Expected behavior
The dialog must be hide when user click out of the dialog.

Minimal reproduction of the problem with instructions
Switch value of "clausable" to see difference.

<Dialog
   onHide={() => {
        this.setState({ DialogOpen: false });
     }}
   header="Testing dialog"
   visible={this.state.DialogOpen}
   closable={false}
   dismissableMask={true}
   footer={footer}
  >
</Dialog>
  • React version:
    17.0.1

  • PrimeReact version:
    5.0.1

  • Browser:
    Firefox, Chrome, Edge, Opera (maybe all)

@mertsincan mertsincan self-assigned this Jan 10, 2021
@mertsincan mertsincan added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Jan 10, 2021
@mertsincan mertsincan added this to the 6.0.0-rc.1 milestone Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

2 participants