Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in tabIndex property name #1710

Closed
pontasan opened this issue Dec 11, 2020 · 1 comment
Closed

Typo in tabIndex property name #1710

pontasan opened this issue Dec 11, 2020 · 1 comment
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@pontasan
Copy link
Contributor

There is no guarantee in receiving an immediate response in GitHub Issue Tracker, If you'd like to secure our response, you may consider PrimeReact PRO Support where support is provided within 4 business hours

I'm submitting a ... (check one with "x")

[X] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

The "i" in tabIndex should be uppercase, not lowercase.
In react, tabindex is wrong. The correct value is tabIndex.

As it is known, when implemented with tabindex, the following warning is also displayed.
"Warning: Invalid DOM property tabindex. Did you mean tabIndex?"

List of implementations that contain typos

  • AutoComplete.js / AutoComplete.d.ts
  • Captcha.js
  • ColorPicker.d.ts
  • InputMask.d.ts
  • InputMask.js

Examples of typos(AutoComplete.js)

static defaultProps = {
...
tabindex: null
...

Correct example(Calendar.js)

static defaultProps = {
...
tabIndex: null
...

@mertsincan mertsincan self-assigned this Dec 15, 2020
@mertsincan mertsincan added the Type: Bug Issue contains a defect related to a specific component. label Dec 15, 2020
@mertsincan mertsincan added this to the 5.1.0 milestone Dec 15, 2020
@mertsincan
Copy link
Member

Hi,
Good catch! I'll fix it.

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

No branches or pull requests

2 participants