Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

findDOMNode is deprecated in StrictMode error on components #1663

Closed
abhaykeerthy12 opened this issue Nov 6, 2020 · 7 comments
Closed

findDOMNode is deprecated in StrictMode error on components #1663

abhaykeerthy12 opened this issue Nov 6, 2020 · 7 comments

Comments

@abhaykeerthy12
Copy link

Current behavior
Using any component that uses react transition group gives findDOMNode is deprecated in StrictMode error.

Expected behavior
Should not give error when using components with react transition group dependency

Minimal reproduction of the problem with instructions
Just use any component with react transition group, like toast, overlay etc

  • React version:
    17.0.1

  • PrimeReact version:
    5.0.1

  • Language: TypeScript 4.0.5

@edw19
Copy link

edw19 commented Nov 9, 2020

I have the same issue
if remove us the strictMode ?

@rubychill
Copy link

Create React App has had a React.StrictMode wrapper on the default template since v3.4.1 so any new CRA projects are going to be seeing these warnings. The only solution currently seems to be disabling strict mode by deleting the wrappers in index.js.

@bitlab-code
Copy link

same here, with prisareact v6

@dattebayorob
Copy link

Hello guys, I Think just removing React.ScritcMode wrapper isnt a valid solution. Is there any plan to update the ref's usage on CssTransition?
https://github.com/reactjs/react-transition-group/releases/tag/v4.4.0

@abhaykeerthy12
Copy link
Author

Removal of React.StrictMode mode in code should not be a solution as it will compromise code quality, its better to re-implement the ref usage

@mertsincan
Copy link
Member

Hi,

Duplicate of #1790

@mertsincan
Copy link
Member

Fixed in #1790

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants