Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click on input filter causes sort #133

Closed
jimjamdev opened this issue Oct 10, 2017 · 3 comments
Closed

Click on input filter causes sort #133

jimjamdev opened this issue Oct 10, 2017 · 3 comments
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@jimjamdev
Copy link

When you click in an input in the DataTable header, it automatically re-orders the data by that column.

https://screenshots.firefox.com/WfF9eAOP21cpz7z9/localhost

It should only re-order when you click outside the input.

@jimjamdev
Copy link
Author

jimjamdev commented Oct 10, 2017

I tried setting e.stopPropagation() on the click & onFilterInput event in HeaderCell.js but no luck.

@jimjamdev
Copy link
Author

Ok, using event.stopPropagation(); inside the input component onClick works

@cagataycivici cagataycivici self-assigned this Oct 11, 2017
@cagataycivici cagataycivici added the Type: Bug Issue contains a defect related to a specific component. label Oct 11, 2017
@cagataycivici cagataycivici added this to the 1.1.0 milestone Oct 11, 2017
@cagataycivici cagataycivici changed the title DataTable: Column auto-reorders when header input is clicked Click on input filter causes sort Oct 12, 2017
@cagataycivici cagataycivici reopened this Oct 31, 2017
@cagataycivici cagataycivici modified the milestones: 1.1.0, 1.1.1 Oct 31, 2017
@jimjamdev
Copy link
Author

Also I should probably open a new issue for this. But from my side resizing columns breaks too. I had to fix it locally with custom drag areas. Then reordering I had to implement outside the grid itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

No branches or pull requests

2 participants