Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputNumber with spinner mode throws a JS exception #9337

Closed
RealNumberX opened this issue Sep 30, 2020 · 1 comment
Closed

InputNumber with spinner mode throws a JS exception #9337

RealNumberX opened this issue Sep 30, 2020 · 1 comment
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@RealNumberX
Copy link

I'm submitting a ... (check one with "x")

[x] bug report 
[ ] feature request 
[ ] support request

Current behavior
TypeError gets thrown when text-field of input-number component is empty and the value is about to be incremented or decremented via buttons.

Expected behavior
TypeError does not get thrown. New value of the field should be 0 +/- [step] if no minimum or maximum boundaries are set.

Minimal reproduction of the problem with instructions

  • Go To PrimeNG Documentation InputSpinner Component
  • In the example with buttons delete the value of the input field
  • open Dev-Tools in browser
  • try to increment or decrement the value
@mertsincan mertsincan changed the title InputNumber TypeError: Cannot read property 'length' of null InputNumber with spinner mode throws a JS exception Oct 7, 2020
@mertsincan mertsincan self-assigned this Oct 7, 2020
@mertsincan mertsincan added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Oct 7, 2020
@mertsincan mertsincan added this to the 10.0.3 milestone Oct 7, 2020
@mertsincan
Copy link
Member

Hi,

Thanks a lot for the PR! However, it had some conflict problems. I guess this was about my previous commits. Sorry for noticing your PR late.

Thanks again for your PR,
Best Regards,

@yigitfindikli yigitfindikli added LTS-PORTABLE Issue's fix will be ported to supported LTS versions LTS-FIXED-9.1.7 and removed LTS-PORTABLE Issue's fix will be ported to supported LTS versions labels Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants