Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement ConfirmDialog Positioning #7164

Closed
cagataycivici opened this issue Jan 23, 2019 · 0 comments
Closed

Reimplement ConfirmDialog Positioning #7164

cagataycivici opened this issue Jan 23, 2019 · 0 comments
Assignees
@cagataycivici
Labels
Type: Breaking Change Issue contains a breaking change related to a specific component Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
7.0.5

Comments

@cagataycivici
Copy link
Member

Use a CSS approach like DynamicDialog to center the position and handle responsiveness. Remove positionLeft, positionTop, breakpoint and responsive props.
@cagataycivici cagataycivici added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Type: Breaking Change Issue contains a breaking change related to a specific component labels Jan 23, 2019
@cagataycivici cagataycivici added this to the 7.0.5 milestone Jan 23, 2019
@cagataycivici cagataycivici self-assigned this Jan 23, 2019
@cagataycivici cagataycivici mentioned this issue Jan 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

Labels
Type: Breaking Change Issue contains a breaking change related to a specific component Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
7.0.5
Development

No branches or pull requests
1 participant
@cagataycivici