Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfirmDialog appendTo is broken #6362

Closed
slinlee opened this issue Aug 20, 2018 · 0 comments
Closed

ConfirmDialog appendTo is broken #6362

slinlee opened this issue Aug 20, 2018 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@slinlee
Copy link

slinlee commented Aug 20, 2018

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting

Plunkr Case (Bug Reports)
https://stackblitz.com/edit/github-knoa7y?file=src/app/app.component.html

Current behavior
Click the button to open the confirmation dialog. Notice that:

  • No modal backdrop
  • The dialog is positioned inline and not on top of anything
  • The console shows the error:
ERROR TypeError: "this.el.nativeElement.children[0] is undefined"
primeng6.1.0/components/confirmdialog/confirmdialog.js:133:9primeng6.1.0/components/confirmdialog/confirmdialog.js:65:17View_ConfirmDialog_1ng:///ConfirmDialogModule/ConfirmDialog.ngfactory.js:129:23core6.1.2/bundles/core.umd.js:10277:20core6.1.2/bundles/core.umd.js:11370:26core6.1.2/bundles/core.umd.js:11073:16core6.1.2/bundles/core.umd.js:7736:20core6.1.2/bundles/core.umd.js:8180:42browser6.1.2/bundles/platform-browser-animations.umd.js:220:29browser6.1.2/bundles/platform-browser-animations.umd.js:218:25js0.8.26/dist/zone.js:388:17core6.1.2/bundles/core.umd.js:3882:28js0.8.26/dist/zone.js:387:17js0.8.26/dist/zone.js:138:24core6.1.2/bundles/core.umd.js:3796:20browser6.1.2/bundles/platform-browser-animations.umd.js:217:21js0.8.26/dist/zone.js:388:17js0.8.26/dist/zone.js:138:24js0.8.26/dist/zone.js:872:29js0.8.26/dist/zone.js:421:17js0.8.26/dist/zone.js:188:28js0.8.26/dist/zone.js:595:25js0.8.26/dist/zone.js:500:21js0.8.26/dist/zone.js:1540:9js0.8.26

Expected behavior
At least in version 6.0.0, the dialog would be shown on a modal backdrop, on top of all other elements on screen, and no errors would be displayed in the console.

Minimal reproduction of the problem with instructions
Use the instructions with the Plunkr below
https://stackblitz.com/edit/github-knoa7y?file=src/app/app.component.html

@cagataycivici cagataycivici self-assigned this Aug 29, 2018
@cagataycivici cagataycivici added this to the 6.1.3 milestone Aug 29, 2018
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Aug 29, 2018
@cagataycivici cagataycivici changed the title ConfirmDialog appendTo broke in recent version ConfirmDialog appendTo is broken Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants