Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OverlayPanel doesn't close on iPhone #5870

Closed
Ajax-ua opened this issue Jun 7, 2018 · 2 comments
Closed

OverlayPanel doesn't close on iPhone #5870

Ajax-ua opened this issue Jun 7, 2018 · 2 comments
Assignees
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@Ajax-ua
Copy link

Ajax-ua commented Jun 7, 2018

When trying to close overlay panel clicking outside of panel on iphone (ios 11.x) it doesn't close.
While debugging I found out that document click listener isn't triggered for some reasons:

    bindDocumentClickListener() {
        if(!this.documentClickListener && this.dismissable) {
            this.documentClickListener = this.renderer.listen('document', 'click', () => {
                if(!this.selfClick && !this.targetClickEvent) {
                    this.hide();
                }
                
                this.selfClick = false;
                this.targetClickEvent = false;
                this.cd.markForCheck();
            });
        }
    }

Maybe it is related to 'click' event. Tried to replace event with 'touchend' and it worked properly for iphone.

@opetriienko
Copy link

Same for me. Can be reproduced even here: https://primefaces.org/primeng/#/overlaypanel

@opetriienko
Copy link

It seems it could be related to this issue: #2380

@cagataycivici cagataycivici self-assigned this Jan 11, 2019
@cagataycivici cagataycivici added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Status: Pending Review Issue or pull request is being reviewed by Core Team labels Jan 11, 2019
@cagataycivici cagataycivici added this to the 7.0.5 milestone Jan 11, 2019
@cagataycivici cagataycivici changed the title p-overlayPanel doesn't close on iPhone OverlayPanel doesn't close on iPhone Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants