Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled dropdown still can be cleared #5286

Closed
ASK83 opened this issue Mar 7, 2018 · 1 comment
Closed

Disabled dropdown still can be cleared #5286

ASK83 opened this issue Mar 7, 2018 · 1 comment
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@ASK83
Copy link

ASK83 commented Mar 7, 2018

There is no guarantee in receiving an immediate response in GitHub Issue Tracker, If you'd like to secure our response, you may consider PrimeNG PRO Support where support is provided within 4 business hours

I'm submitting a ... (check one with "x")

[X] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
Please fork the plunkr below and create a case demonstrating your bug report. Issues without a plunkr have much less possibility to be reviewed.

http://plnkr.co/edit/kp2rDPVGXyQgQIfhrnPB?p=preview

Current behavior
You can clear the preselected value even when the dropdown is set to be disabled.

Expected behavior
Not be able to clear a disabled dropdown. It would even be a good idea to give the user the functionality to have or not to have the clear button.

Minimal reproduction of the problem with instructions
plunker shows the issue

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

  • Angular version: 2.0.X

5.2.0

  • PrimeNG version: 2.0.X
    5.2.1

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
    All

  • Language: [all | TypeScript X.X | ES6/7 | ES5]

  • Node (for AoT issues): node --version =

@billfranklin
Copy link

Must agree with this. You should always honor the status of the control.

@cagataycivici cagataycivici self-assigned this Mar 9, 2018
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Mar 9, 2018
@cagataycivici cagataycivici added this to the 5.2.2 milestone Mar 9, 2018
@cagataycivici cagataycivici changed the title p-dropdown clearvalue icon is clearing even when the control is set to disabled Disabled dropdown still can be cleared Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants