Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slideMenu ignores styleClass on MenuItem model properties #5253

Closed
blackholegalaxy opened this issue Mar 2, 2018 · 3 comments
Closed

slideMenu ignores styleClass on MenuItem model properties #5253

blackholegalaxy opened this issue Mar 2, 2018 · 3 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@blackholegalaxy
Copy link

[Copy from forum]

I'm submitting a ... (check one with "x")

[x] bug report 
[ ] feature request
[ ] support request

SlideMenu seems to ignore some MenuItem model properties. For example, defining an item styleClass is totally ignored.

Repro here:
https://stackblitz.com/edit/prime-slidemenu-bug-r8gjno?file=app%2Fapp.component.ts

As you can see if I add styleClass: 'any-custom-class' on the language menu item element, it's completely ignored and is not applied anywhere on the menu.

Image

I found the same applies for badge or badge style class. The others seem to work properly.

@cagataycivici cagataycivici self-assigned this Mar 4, 2018
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Mar 4, 2018
@cagataycivici cagataycivici added this to the 5.2.1 milestone Mar 4, 2018
@blackholegalaxy
Copy link
Author

@cagataycivici thanks for fix. Sorry about missplacement of these on my PR.

Please note the badge and badgeStyleClass properties of MenuItem is also ignored here and maybe should be added in all menus using MenuItem model.

@cagataycivici
Copy link
Member

badges are used in menus premium templates at the moment as far as I know, we sure can add support to p-menu* as well in the future.

@diamond-darrell
Copy link
Contributor

@cagataycivici please do 🙂

we sure can add support to p-menu* as well in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants