Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"disabled" property not working on tableRadioButton and tableCheckbox #5095

Closed
UrzaUrza opened this issue Feb 7, 2018 · 7 comments
Closed
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@UrzaUrza
Copy link

UrzaUrza commented Feb 7, 2018

I'm submitting a ...

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior
When the "disabled" property is set to true on tableRadioButton or tableCheckbox, the row is still selectable.

Expected behavior
When the "disabled" property is set to true on tableRadioButton or tableCheckbox, the row is not selectable.

  • PrimeNG version: 5.2.0
@sashaSavych
Copy link

The same for me :(
"disabled" property sets just style

@jun58
Copy link

jun58 commented Mar 21, 2018

It same for me ~~

@noamichael
Copy link

I submitted a PR:

#5515

@cagataycivici cagataycivici self-assigned this Apr 17, 2018
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Apr 17, 2018
@cagataycivici cagataycivici added this to the 5.2.5 milestone Apr 17, 2018
@cagataycivici
Copy link
Member

Set to 5.2.5.

@cagataycivici
Copy link
Member

PR merged, thank you.

@jmaruiz
Copy link

jmaruiz commented May 18, 2018

Can you do the same with tableHeaderCheckbox? That does not obey disabled styling or functionality.

@noamichael
Copy link

@jmaruiz Created a pull request to fix this (#5761). Sorry I missed that the first time around!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

6 participants