Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Dialog Accessibility #4161

Closed
ghost opened this issue Oct 12, 2017 · 1 comment
Closed

Improve Dialog Accessibility #4161

ghost opened this issue Oct 12, 2017 · 1 comment
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@ghost
Copy link

ghost commented Oct 12, 2017

I'm submitting a ... (check one with "x")

[ x ] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior
Screen readers have trouble reading the dialog because it is missing several aria/role attributes

Expected behavior
Dialog should function appropriately with screen readers

  • Angular version: 2.0.X
    4.3.5

  • PrimeNG version: 2.0.X
    4.2.2

  • Browser:
    Chrome 61

  • Language: [all | TypeScript X.X | ES6/7 | ES5]
    Typescript 2.2

@ghost ghost mentioned this issue Oct 12, 2017
@cagataycivici cagataycivici self-assigned this Oct 19, 2017
@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Oct 19, 2017
@cagataycivici cagataycivici added this to the 4.2.3 milestone Oct 19, 2017
@cagataycivici cagataycivici changed the title p-dialog accessibility Improve Dialog Accessibility Oct 19, 2017
@cagataycivici
Copy link
Member

Added role="dialog" and ariaLabelledBy property as well to provide the id of the header element that maps to aria-labelledby of dialog. So defining ariaLabelledBy is suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

1 participant