Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Schedule to FullCalendar 3.5.0 #3813

Closed
vadjs opened this issue Sep 1, 2017 · 5 comments
Closed

Update Schedule to FullCalendar 3.5.0 #3813

vadjs opened this issue Sep 1, 2017 · 5 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@vadjs
Copy link

vadjs commented Sep 1, 2017

There is no guarantee in receiving a response in GitHub Issue Tracker, If you'd like to secure our response, you may consider PrimeNG PRO Support where support is provided within 4 business hours

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior

Ater updating FullCalendar package to v3.5.0 here are appears error Cannot read property 'url' of undefined
Fullcalendar v3.5.0 have major changes. That's why problem appeared.

Expected behavior

No errors

Minimal reproduction of the problem with instructions

Use last version of PrimeNG(4.2.0-rc.1).
Use last version of FullcCalendar.
Get error in any case.

What is the motivation / use case for changing the behavior?

Worning module.

Please tell us about your environment: windows

  • Angular version: 4.3.6
  • PrimeNG version: 4.2.0-rc.1
  • Browser: all
  • Language: all

  • Node (for AoT issues): node --version = 8.1.3

@baljeet
Copy link

baljeet commented Sep 2, 2017

Any luck with the issue? I am also facing the same error

@tplessis
Copy link

tplessis commented Sep 4, 2017

Same here, but only in production with AOT. Going back to version 3.4.* of fullcalendar fixed the issue.

@baljeet
Copy link

baljeet commented Sep 4, 2017

Thanks @tplessis
Worked for me as well.

@200ljx
Copy link

200ljx commented Sep 8, 2017

@tplessis Thanks a lot!

@cagataycivici cagataycivici changed the title [Schedule] Cannot read property 'url' of undefined Update Schedule to FullCalendar 3.5.0 Sep 11, 2017
@cagataycivici cagataycivici self-assigned this Sep 11, 2017
@cagataycivici cagataycivici modified the milestones: 4.2.1, 4.2 Sep 11, 2017
@cagataycivici
Copy link
Member

Adding a null check fixed the issue;

2f5dda0

@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Sep 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

5 participants