Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chips - Add new chip on Tab keypress #3527

Closed
nmobregon opened this issue Jul 28, 2017 · 3 comments
Closed

Chips - Add new chip on Tab keypress #3527

nmobregon opened this issue Jul 28, 2017 · 3 comments
Assignees
Labels
Type: New Feature Issue contains a new feature or new component request
Milestone

Comments

@nmobregon
Copy link

I'm submitting a ...

[ ] bug report => Search github for a similar issue or PR before submitting
[ x ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior
The items are added only when I press Enter key

Expected behavior
Would be great to have the text I'm writing appended as new chip on Tab key press.
For multiple mail inputs, this is the most popular way of handling it.

Minimal reproduction of the problem with instructions
Write text in p-chips component, press tab, and the cursor moves to the next component instead of adding a new chip

What is the motivation / use case for changing the behavior?
Users are used to input mail addresses this way

  • PrimeNG version: 4.1.0-rc.2

  • Browser: [Chrome]

Thanks in advance

@huseyinturkmenoglu
Copy link
Contributor

I solved this problem, and i sended 'pull request'.

It's here : #3565

@cagataycivici cagataycivici self-assigned this Aug 8, 2017
@cagataycivici cagataycivici added the Type: New Feature Issue contains a new feature or new component request label Aug 8, 2017
@cagataycivici cagataycivici added this to the 4.1.3 milestone Aug 8, 2017
@nmobregon
Copy link
Author

Hi, thanks @cagataycivici for implementig the tab button functionality.
Testing it I've found that you cannot focus next field when chips input element is empty.

Here is the issue for that "bug"(¿?), guess so, because you get trapped in the component when addOnTab is enabled

Thanks!

@huseyinturkmenoglu
Copy link
Contributor

I added a pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Development

No branches or pull requests

3 participants