Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Dialog events #2413

Closed
cagataycivici opened this issue Mar 29, 2017 · 1 comment
Closed

Rename Dialog events #2413

cagataycivici opened this issue Mar 29, 2017 · 1 comment
Assignees
@cagataycivici
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
4.0.RC2

Comments

@cagataycivici
Copy link
Member

Remove onAfterHide and onAfterShow, rename onBeforeHide and onBeforeShow to onHide and onShow to align with other components.
@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Mar 29, 2017
@cagataycivici cagataycivici added this to the 4.0.RC2 milestone Mar 29, 2017
@cagataycivici cagataycivici self-assigned this Mar 29, 2017
@cagataycivici cagataycivici mentioned this issue Mar 31, 2017
Closed
@GabKas
Copy link

GabKas commented Apr 4, 2017

Hi,

the following fix: ec06e44
was removed the ngAfterViewChecked lifecycle hook in 4.0.0-rc.2.

Unfortunately the dialog does not open in the center of viewport anymore.
Because the center() function can not calculate the elementHeight properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
4.0.RC2
Development

No branches or pull requests
2 participants
@cagataycivici @GabKas