Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable filter is not cleared when ::-ms-clear is clicked #2179

Closed
sliekens opened this issue Feb 28, 2017 · 4 comments
Closed

DataTable filter is not cleared when ::-ms-clear is clicked #2179

sliekens opened this issue Feb 28, 2017 · 4 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@sliekens
Copy link

sliekens commented Feb 28, 2017

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
No Plunkr but the issue exists even in the API sample
http://www.primefaces.org/primeng/#/datatable/filter

Current behavior
Internet Explorer 11 (and possibly IE10 and Edge) add a clear button to input fields. When that button is clicked, the global filter is cleared but the DataTable does not handle that event.

ms-clear

Expected behavior

When the ms-clear button is clicked, the DataTable filter should be reset.

The current workaround is to press the Return key after clicking ms-clear.

Minimal reproduction of the problem with instructions

Open the DataTable filter sample in IE10 or IE11
http://www.primefaces.org/primeng/#/datatable/filter

What is the motivation / use case for changing the behavior?

Users are confused

Please tell us about your environment:

Tested in IE11 on Windows 7

  • Angular version: 2.4.8
  • PrimeNG version: 2.0.1
  • Browser: Internet Explorer 11
  • Language: all

  • Node (for AoT issues): node --version = not applicable

@sliekens
Copy link
Author

sliekens commented Mar 6, 2017

Bump

@sliekens
Copy link
Author

The fundamental problem here is that filtering is applied on keydown instead of on input or on change. Any way to change the filter without pressing a key breaks change detection.

cc @cagataycivici @Mrtcndkn

@cagataycivici cagataycivici self-assigned this Jun 20, 2017
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Jun 20, 2017
@cagataycivici cagataycivici added this to the 4.1.0 milestone Jun 20, 2017
@cagataycivici
Copy link
Member

c4b5549

Fixes this as well.

@sliekens
Copy link
Author

@cagataycivici I just updated to 4.1.0 and the issue still exists when using [globalFilter]="inputRef"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants