Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large dialog content or small screens causes the dialog to be positioned outside the viewport #1925

Closed
howlettt opened this issue Jan 26, 2017 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@howlettt
Copy link
Contributor

I'm submitting a ...

[ x ] bug report

Plunkr Case
http://plnkr.co/edit/sIzRqJnm5TD7ZrbpPJaH?p=preview

Current behavior
When a dialog is larger then the current screen size, the dialog is positioned outside the viewport. For example at position (-100, -100)

Expected behavior
The dialog should be positioned at the top left corner of the screen instead, position (0, 0), or at the corresponding position should the dialog only be too large in one dimension, (0, x) or (x, 0)

Minimal reproduction of the problem with instructions

  • Create a dialog
    <p-dialog header="Godfather I" [(visible)]="display" modal="modal" width="350" responsive="true">
  • Add a ton of text to the dialog
  • Open said dialog

What is the motivation / use case for changing the behavior?
Making the dialog more responsive

@cagataycivici cagataycivici self-assigned this Feb 20, 2017
@cagataycivici cagataycivici added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add labels Feb 20, 2017
@cagataycivici cagataycivici added this to the 2.0.1 milestone Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants