Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in bootstrap theme for growl componemt #1187

Closed
kcsahoo opened this issue Nov 2, 2016 · 7 comments
Closed

Bug in bootstrap theme for growl componemt #1187

kcsahoo opened this issue Nov 2, 2016 · 7 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@kcsahoo
Copy link

kcsahoo commented Nov 2, 2016

The background colour for growl message is always blue whether you show info, warning or error.
This happens in bootstrap theme but is working properly in omega theme.
Please resolve in next rc.

@ctrl-brk
Copy link

ctrl-brk commented Nov 2, 2016

That's becase .ui-growl-item-container.ui-state-highlight.ui-growl-message-... (success, error, etc) are not even defined in the bootstrap theme css. I have this issue reported already. I would say the Omega theme seems to be the one which gets most attention, not all of them.
#1143

@kcsahoo
Copy link
Author

kcsahoo commented Nov 2, 2016

Are you going to update the bootstrap theme with all the features of omega theme?
I can say this theme is more popular than omega.

@apiweb
Copy link

apiweb commented Nov 17, 2016

Same mistake here.
It is always showing the blue background, even if the message is of success or error.

@mrgoos
Copy link

mrgoos commented Nov 30, 2016

Hey, I think that I have the same issue for ultima-primeNG premium theme though it seems black to me and not blue.
Is that what you're experiencing?
screen shot 2016-11-29 at 17 53 59

Also attaching developer tools inspect elements:
screen shot 2016-11-29 at 21 39 34

I have opened a thread in the ultima-primeNG forum as well:
http://forum.primefaces.org/viewtopic.php?f=45&t=48333&sid=4f8b4d115c82ff3f0c76499fbf1d7d00

Also waiting for a solution.

I also see this in ultima-primeNG demo page...
http://www.primefaces.org/ultima-ng/#/messages

@cagataycivici cagataycivici assigned jfarcand and Mrtcndkn and unassigned jfarcand Nov 30, 2016
@cagataycivici cagataycivici added this to the 1.0.2 milestone Nov 30, 2016
@cagataycivici cagataycivici added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Nov 30, 2016
@Mrtcndkn
Copy link
Contributor

Mrtcndkn commented Dec 5, 2016

Hi,

Duplicate of #1143

@mrgoos In ultima its designed according to the material specs so it's not a bug when you are using ultima.But you can always easily change it for example

.ui-growl-item-container.ui-state-highlight.ui-growl-message-info { background: blue; }

@Mrtcndkn Mrtcndkn closed this as completed Dec 5, 2016
@cagataycivici
Copy link
Member

We've decided to give colors to Ultima Growl as well in next version.

@mrgoos
Copy link

mrgoos commented Dec 13, 2016

Thanks a lot for this @cagataycivici

@cagataycivici cagataycivici added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

7 participants