Tabmenu highlights wrong menuitem when has routerLinkActiveOptions set as exact

[Jonnyprof]

I'm submitting a ... (check one with "x")

[X] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
https://stackblitz.com/edit/github-faf8r7

Current behavior
When the p-tabMenu contains a model attribute that refers to an array containing items with a routerLink and one of them is exact route, this one is always highlighted.

Expected behavior
Only the menu item corresponding with the route should be highlighted.

Minimal reproduction of the problem with instructions
Go to stackblitz and navigate between pages. Menu item "home" is always highlighted (with default css theme).

Cause of the problem
Last parameter of this.router.isActive is exact and is false. It should be true to get "exact" option properly..

primeng/src/app/components/tabmenu/tabmenu.ts

Lines 120 to 128 in ab48dda

	isActive(item: MenuItem) {
	if (item.routerLink){
	let routerLink = Array.isArray(item.routerLink) ? item.routerLink : [item.routerLink];
	return this.router.isActive(this.router.createUrlTree(routerLink, {relativeTo: this.route}).toString(), false);
	}
	return item === this.activeItem;
	}

What is the motivation / use case for changing the behavior?
Tabmenu works wrong and it's confusing.

Please tell us about your environment:
Ubuntu 20.04.4 LTS

• Angular version: 5.X
  13.3.2

• PrimeNG version: 5.X
  13.3.2

• Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
  All browsers

• Language: [all | TypeScript X.X | ES6/7 | ES5]
  All

[Jonnyprof]

This issue is still present in primeNG 14.0.2.

[majkers]

14.1.2 still the same

[mertsincan]

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you reopen the issue so we can include it in our roadmap?
Please don't forget to add your feedback as a comment after reopening the issue. These will be taken into account by us and will contribute to the development of this feature. Thanks a lot for your understanding!

Best Regards,

[majkers]

@Jonnyprof @mertsincan I think this isssue still exist https://github.com/primefaces/primeng/blob/master/src/app/components/tabmenu/tabmenu.ts
Please reopen it

[Jonnyprof]

This issue is still happening, because the isActive method hasn't changed.

[Jonnyprof]

@mertsincan please reopen it, I can't

[majkers]

I also think that isActive method should include queryParams in its check

[github-actions]

Due to PrimeNG team's busy roadmap, this issue is available for anyone to work on. Make sure to reference this issue in your pull request. ✨ Thank you for your contribution! ✨