Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sidebar causes javascript error if modal=false #10813

Closed
wittdavid opened this issue Nov 5, 2021 · 0 comments
Closed

sidebar causes javascript error if modal=false #10813

wittdavid opened this issue Nov 5, 2021 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@wittdavid
Copy link

If you have a PrimeNG PRO Support subscription please post your issue at;

https://pro.primefaces.org

where our team will respond within 4 business hours.

If you do not have a PrimeNG PRO Support subscription, fill-in the report below. Please note that
your issue will be added to the waiting list of community issues and will be reviewed on a first-come first-serve basis, as a result, the support team is unable to guarantee a specific schedule on when it will be reviewed. Thank you for your understanding.

Current Queue Time for Review
Without PRO Support: ~8-12 weeks.
With PRO Support: 1 hour

I'm submitting a ... (check one with "x")

[X] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
Please demonstrate your case at stackblitz by using the issue template below. Issues without a test case have much less possibility to be reviewd in detail and assisted.

https://stackblitz.com/github/primefaces/primeng-issue-template

Current behavior
Sidebar - ngOnDestroy() calls destroyModal() which causes error "Failed to execute 'removeChild' on 'Node': parameter 1 is not of type 'Node'".

SPECIFIC CONDITION - input parameter "modal" is set to false. As a result. enableModality() will NOT be called, and therefore "this.mask" will be null.

Expected behavior
No javascript error.

Minimal reproduction of the problem with instructions
Set input parameter "modal" to false. Make sidebar visible. Cause page transition that results in ngOnDestroy() to be called.

Need to check if "this.mask" before attempting to call removeChild().

Broken as part of commit for: #10639

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

  • Angular version: 5.X
  • PrimeNG version: 5.X
    12.2.1

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

  • Language: [all | TypeScript X.X | ES6/7 | ES5]

  • Node (for AoT issues): node --version =

@yigitfindikli yigitfindikli self-assigned this Nov 8, 2021
@yigitfindikli yigitfindikli added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Nov 8, 2021
@yigitfindikli yigitfindikli added this to the 13.0.0-rc.2 milestone Nov 8, 2021
@yigitfindikli yigitfindikli added LTS-PORTABLE Issue's fix will be ported to supported LTS versions and removed LTS-PORTABLE Issue's fix will be ported to supported LTS versions labels Nov 8, 2021
@yigitfindikli yigitfindikli modified the milestones: 13.0.0-rc.2, 13.0.0-rc.1 Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants