Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-multiselect: Performance issue when selecting all items (10000 records or more) #10695

Closed
ManojKChowdhury opened this issue Sep 29, 2021 · 3 comments
Assignees
Labels
Type: New Feature Issue contains a new feature or new component request

Comments

@ManojKChowdhury
Copy link

In scenarios when there are huge numbers of records in the multiselect dropdown, activating virtual scroll enables smooth open-close of the dropdown. But upon clicking the select-all checkbox:

It takes around 13-14 seconds for the checkbox to be shown as selected and the dropdown to be usable again.
The page becomes unusable during this duration.
Closing the dropdown now and re-opening it with all items selected also takes a lot of time.
De-selecting all items by clicking on the checkbox again takes considerable time.

@TUSHAR4541
Copy link

Yes for me as well, Select all/Unselect all takes a lot of time. Here is a sample with 4000 records only https://stackblitz.com/edit/primeng-multiselect-demo-sghybu

Even with virtualScroll option this fails.

@mertsincan
Copy link
Member

mertsincan commented Jul 20, 2022

Hi,
Similar to primefaces/primereact#2098. I think these options can be added to PrimeNG MultiSelect component. Demo;
https://www.primefaces.org/primereact/multiselect/ (VirtualScroller demo)

@mertsincan mertsincan added this to the 14.Future milestone Jul 20, 2022
@mertsincan mertsincan added the Type: New Feature Issue contains a new feature or new component request label Jul 20, 2022
@mertsincan mertsincan modified the milestones: 14.Future, 14.2.1 Nov 8, 2022
@mertsincan
Copy link
Member

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you reopen the issue so we can include it in our roadmap?
Please don't forget to add your feedback as a comment after reopening the issue. These will be taken into account by us and will contribute to the development of this feature. Thanks a lot for your understanding!

Best Regards,

@mertsincan mertsincan removed this from the 14.2.2 milestone Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: New Feature Issue contains a new feature or new component request
Projects
None yet
4 participants