Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-dialog breakpoints is not working #10270

Closed
szabto opened this issue May 24, 2021 · 3 comments
Closed

p-dialog breakpoints is not working #10270

szabto opened this issue May 24, 2021 · 3 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@szabto
Copy link

szabto commented May 24, 2021

[x] bug report

Current behavior
Cannot use the correct form of breakpoints in p-dialog component because of its type.
The type is currently an any[] which should be an object.

[breakpoints]="{'960px': '75vw', '640px': '100vw'}"
Got error: Object literal may only specify known properties, and '"960px"' does not exist in type 'any[]'.

Expected behavior
The type of the breakpoints property should be changed to {}

What is the motivation / use case for changing the behavior?
I wanted to make my dialog responsive, like in the example.

Please tell us about your environment:

  • Angular version: 11.2.4
  • PrimeNG version: 11.3.2
  • Browser: all
  • Language: TypeScript 4.1.5
  • OS: MacOS Big Sur
@jerrypp
Copy link

jerrypp commented May 25, 2021

I have the same problem

@yigitfindikli yigitfindikli added the Status: Pending Review Issue or pull request is being reviewed by Core Team label May 25, 2021
@yigitfindikli yigitfindikli added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Jun 4, 2021
@yigitfindikli yigitfindikli self-assigned this Jun 4, 2021
@yigitfindikli yigitfindikli added this to the 12.0.0-Final milestone Jun 4, 2021
@yigitfindikli yigitfindikli added the LTS-PORTABLE Issue's fix will be ported to supported LTS versions label Jun 4, 2021
@yigitfindikli yigitfindikli added LTS-FIXED-11.4.6 and removed LTS-PORTABLE Issue's fix will be ported to supported LTS versions labels Oct 1, 2021
@seralej
Copy link

seralej commented Nov 10, 2021

Hello all, im new at developing and having the reported issue, how can i solve it?

@mohdsaad17
Copy link

@seralej Just make sure that you are using primeng version 12 or above and it will be resolved.(Check in your package.json file).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

5 participants