Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message -> from version 17.16 no more "error" but "danger" #134

Open
meriturva opened this issue May 10, 2024 · 4 comments
Open

Message -> from version 17.16 no more "error" but "danger" #134

meriturva opened this issue May 10, 2024 · 4 comments

Comments

@meriturva
Copy link

The latest version of Primeng just replace "error" message type with "danger" one:

https://github.com/primefaces/primeng/blob/master/src/app/components/message/message.ts#L39

So basically sass doesn't work anymore:

I still don't catch why primeng demo site doesn't use this package!

@meriturva
Copy link
Author

@cetincakiroglu If necessary I could make a PR easily....tell me.

@gbalatckii
Copy link

Still relevant in version 17.18.0

@cetincakiroglu
Copy link
Contributor

cetincakiroglu commented Jul 1, 2024

Hi,

Thanks for reporting the issue.

Correct severity options for the message and toast components should be as follows:

severity: 'success' | 'info' | 'warn' | 'error' | 'secondary' | 'contrast' | undefined;

Possibly, this issue stems from a problem occurring when merging branches in PrimeNG repo.

Styles are correct, classes should be -error & -warn. This issue will be fixed in PrimeNG 17.18.3 release this week.

@Phillip9587
Copy link

@cetincakiroglu Still relevant in version 17.18.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants