Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest Day Planner version broke theme support for it #268

Open
gnakic opened this issue Feb 4, 2025 · 0 comments
Open

Latest Day Planner version broke theme support for it #268

gnakic opened this issue Feb 4, 2025 · 0 comments
Labels
🧞‍♂️ enhancement Suggestion for visual improvements, and style settings customization

Comments

@gnakic
Copy link

gnakic commented Feb 4, 2025

Primary Theme Version

v2.11.0

Debug Info

Latest versions of the Day Planner plugin refactored and re-arranged a bunch of css classes, that essentially broke efforts by @ceciliamay to support it in the latest beta of Primary (v2.11.0)

While the Day Planner looked the same in the beta as it was on stable, it also introduced a sidebar to the right, instead of having buttons on the title bar to control the weekday view (allegedly people had issue with it as they would disable the title bar).

Describe the enhancement

I essential forked the repo (found here) and did the following for Day Planner:

  • made bug fixes to beta changes so that the styling in Primary is applied to latest css classes properly
  • I really didn't like how the sidebar fits against the general vibe in Primary (whatever I did to it, I didn't like the sharp corners that it left on the view), so I switched to be a floating bar at the bottom (form over function if you will, but looks good on mobile and gives more space on it)

so, here's a before

Image

and after

Image

If my changes make sense, I would love to open a PR for it 🙂

(P.S. the left editor shows initial support for Dataview. I've just styled the Dataview tables to be consistent with the markdown ones)

@gnakic gnakic added the 🧞‍♂️ enhancement Suggestion for visual improvements, and style settings customization label Feb 4, 2025
@gnakic gnakic changed the title Last Day Planner version broke theme support for it Latest Day Planner version broke theme support for it Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧞‍♂️ enhancement Suggestion for visual improvements, and style settings customization
Projects
None yet
Development

No branches or pull requests

1 participant