flash.py and other python scripts does not work on Arch Linux

[erikw]

Version: prey-node-client 1.3.6
OS: Arch Linux

Currently the feature of sending messages to a Arch Linux laptop does not work. This is because
/opt/prey-node-client/lib/agent/actions/alert/linux/flash.py is a python2 script but in arch the binary "python" is a symlink to python3.

Update:
The same goes for /opt/prey-node-client/lib/agent/actions/lock/linux/pre-lock and all other python scripts.

[mauricioschneider]

Hello @erikw,

Thanks for reporting the issue. We are aware of the python2/python3 issue in Arch Linux since it was exposed in #63. I'm currently downloading said distribution to try to deal with this and other issues.

[erikw]

Alright cool! :)

[erikw]

Also, a wonder. What's up with the weird header in the sh-python files?

#!/bin/sh
''':'
':'; python=$(command -v python)
':'; [ -z "$python" ] || [ -n "${python##*usr*}" ] && python="/usr/bin/python"
':'; exec "$python" "$0" "$@"

Wouldn't a simple env in the shebang do it?

#!/usr/bin/env python

[mauricioschneider]

Thanks @erikw for your feedback. Most likely 1.3.8 will address most of them (that's because 1.3.7 it's already on the way).

[tomas]

That wried shebang attempts to locate the correct python path in order to execute the script. Normally a /usr/bin/env python should do it, but there are cases in which there's a local python (e.g. installed via homebrew) that does not contain the required modules for the script to run.

[beeatriz]

User's output of journalctl: when executing LOCK:

Jul 23 12:26:16 warchx su[6130]: (to wesley) root on none

Jul 23 12:26:16 warchx su[6130]: pam_unix(su:session): session opened for
user wesley by (uid=0)
Jul 23 12:26:16 warchx su[6130]: pam_unix(su:session): session closed for
user wesley
Jul 23 12:26:16 warchx sudo[6129]: pam_unix(sudo:session): session closed
for user root
Jul 23 12:26:16 warchx sudo[6138]: prey : TTY=unknown ;
PWD=/opt/prey-node-client/lib/agent/actions/lock/linux ; USER=root ;
COMMAND=/usr/sbin/su wesley -c
"/opt/prey-node-client/lib/agent/actions/lock/linux/prey-lock"
"e8d95a51f3af4a3b134bf6bb680a213a"
Jul 23 12:26:16 warchx sudo[6138]: pam_unix(sudo:session): session opened
for user root by (uid=0)

Jul 23 12:26:16 warchx su[6139]: (to wesley) root on noneJul 23 12:26:16
warchx su[6139]: pam_unix(su:session): session opened for user wesley by
(uid=0)Jul 23 12:26:16 warchx su[6139]: pam_unix(su:session): session
closed for user wesleyJul 23 12:26:16 warchx sudo[6138]:
pam_unix(sudo:session): session closed for user rootJul 23 12:28:22 warchx
sudo[7109]: prey : TTY=unknown ;
PWD=/opt/prey-node-client/lib/agent/actions/lock/linux ; USER=root ;
COMMAND=/usr/sbin/su wesley -c
"/opt/prey-node-client/lib/agent/actions/lock/linux/prey-lock"
"e8d95a51f3af4a3b134bf6bb680a213a"
(it repeats until I stop the action! ...)

He recorded the screen showing what happens: http://youtu.be/ShjmSHtaKzc

[wcota]

Just changed

#!/bin/sh
''':'
':'; python=$(command -v python)
':'; [ -z "$python" ] || [ -n "${python##*usr*}" ] && python="/usr/bin/python"
':'; exec "$python" "$0" "$@"
'''

to

#!/usr/bin/env python2

in file /opt/prey-node-client/lib/agent/actions/lock/linux/prey-lock and now it works. :)

With the first code, Arch Linux still uses python3.

[mauricioschneider]

Thanks for the feedback @wesleycota. There are some other priorities in the pipeline right now, but I'll look into the issue as soon as possible.

[JotaRandom]

as a reminder, the weird lined pointed by erikw on 15 Jan 2015 still present and ALL the envs still point to python where not all distros have python as version 2 interpreter.
so for future references Arch use this patch https://aur.archlinux.org/cgit/aur.git/tree/prey-node-client.patch?h=prey-node-clientbto fix it and add arch specific tweaks (no autoupdate for example)