Extension does not work with new versions of eslint

[exsesx]

Prettier cannot resolve the eslint configuration and uses fallback options instead of eslint rules (prettier.eslintIntegration: true)

The issue is reproduced using the eslint versions:

• 5.15.2
• 5.15.3

The solution for me at the moment is downgrade eslint to 5.15.1

[rimatla]

Any updates? Prettier stopped working out of the blue today, I didn't update anything unless VSC updated itself under the hood.

[icyJoseph]

We've run into the same issue. Prettier is not applying our eslint rules.

Eslint version: 5.15.3
Prettier: 1.16.4

VS-code extension: 1.18.1

Downgrading to 5.15.1 does fix the issue.

[through-a-haze]

Same here. Downgrading eslint doesn't help. I have

"space-before-function-paren": [
      "error",
      {
        "anonymous": "always",
        "named": "never",
        "asyncArrow": "always"
      }
    ]

in my eslint rules and it used to work but today Prettier started removing spaces between "function" keyword and parentheses in anonymous functions.

[Titozzz]

We started seeing the same issues. Any more info needed to reproduce the issue?

[bradennapier]

Same info - extension is dead?

[through-a-haze]

It seems to work again for me. Don't know why, didn't do anything.
eslint -v
v5.15.3

prettier -v
1.16.4

[jhpratt]

Doesn't appear to work at all for me, disabling prettier until further notice. I imagine others will be doing the same.

[adrienharnay]

Downgrading to 5.15.1 does fix the issue.

As @icyJoseph said, downgrading Eslint to 5.15.1 fixes the issue.

[muhozi]

Downgrading doesn't work.

eslint -v
v5.15.1
prettier -v
1.16.4

[icyJoseph]

Downgrading doesn't work.

eslint -v
v5.15.1
prettier -v
1.16.4

Perhaps a dependency is forcing a higher version of eslint on your project? What does yarn why eslint print? Anyway, the extension should work with any version. Should we investigate what changed from 5.15.1 to 5.15.2, fix it and submit a PR?

[muhozi]

I'm using eslint 5.16.0(installed globally not in the project locally). In my case, I had this package called Beautify(hookyqr.beautify) and it was the one messing with my prettier.

In addition, other formatting packages may cause prettier not to work as expected as it was mentioned in the prettier vscode README

[jca41]

Same problem here. After the vscode updated to 1.33.0 (osx) prettier is now applying the fallback rules.
eslint integration is enabled on settings.

[timmeade]

Adding my 2 cents . osx . stopped working with vscode 1.33.0

eslint 5.16.0 or 5.15.1 neither works.

[timmeade]

I just downgraded VSCode to Version 1.32.3 (1.32.3) and everything is working again

[exsesx]

Any updates?

[CiGit]

Have some of you tried with prettier-eslint's CLI with different eslint version ? Trying to narrow down the issue.

[quentez]

@CiGit The prettier-eslint command works for us with ESLint 5.16.0. But not in VSCode.

[bradzacher]

Unless I'm mistaken, the problem is that this extension bundles its own version of prettier-eslint - which means it also has its own version of eslint@^4.0.0.

This means that even if you have eslint installed locally, the extension will run the lint and fixers with its local version of eslint 4.
In a lot of cases it'll work, but there are missing things (like support for scoped plugins).

At least that was what I found when I was investigating why patching in my fix locally didn't fix the extension (I had to go into the vscode extension folder and patch it there for it to work).

[ntotten]

Duplicate of #870

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.