9.16 fails to load from custom prettierPath #3041

vsiao · 2023-06-23T01:50:32Z

Summary

In 9.16, when configured with a path to the prettier module (eg. node_modules/prettier), the extension fails to load.

Steps To Reproduce:

Set prettier.prettierPath config to node_modules/prettier

Expected result

Extension loads node_modules/prettier/package.json successfully.

Actual result

Extension fails to load. The extension appears to look for node_modules/packages.json, then package.json, etc.

Additional information

VS Code Version: 1.79.2

Prettier Extension Version: 9.16

OS and version: Mac OS Ventura 13.4

Prettier Log Output

Below trace is from #3038 (comment). cc @mreduar

["INFO" - 1:39:28 PM] Extension Name: esbenp.prettier-vscode.
["INFO" - 1:39:28 PM] Extension Version: 9.16.0.
["INFO" - 1:39:28 PM] Attempted to load Prettier module from /var/www/html/node_modules/prettier
["ERROR" - 1:39:28 PM] Failed to load module. If you have prettier or plugins referenced in package.json, ensure you have run `npm install`
["ERROR" - 1:39:28 PM] Cannot load Prettier version from package.json
Error: Cannot load Prettier version from package.json
    at t.ModuleResolver.loadPrettierVersionFromPackageJson (/root/.vscode-server/extensions/esbenp.prettier-vscode-9.16.0/dist/extension.js:1:3820)
    at t.ModuleResolver.getPrettierInstance (/root/.vscode-server/extensions/esbenp.prettier-vscode-9.16.0/dist/extension.js:1:5025)
    at t.default.handleActiveTextEditorChanged (/root/.vscode-server/extensions/esbenp.prettier-vscode-9.16.0/dist/extension.js:1:10626)
    at t.default.handleActiveTextEditorChangedSync (/root/.vscode-server/extensions/esbenp.prettier-vscode-9.16.0/dist/extension.js:1:10228)
    at t.default.registerDisposables (/root/.vscode-server/extensions/esbenp.prettier-vscode-9.16.0/dist/extension.js:1:13071)
    at /root/.vscode-server/extensions/esbenp.prettier-vscode-9.16.0/dist/extension.js:1:81163
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

The text was updated successfully, but these errors were encountered:

tobz1000 · 2023-06-23T12:39:22Z

I suspect I'm not the only one coming across this bug, having just added prettierPath to my config as a workaround for #3019 😄

spencermefford · 2023-06-23T16:58:35Z

Rolling back to 9.14.0 works for me.

azat-io · 2023-06-23T17:14:17Z

@spencermefford How can I roll back VS Code extension version?

vsiao · 2023-06-23T17:22:34Z

https://stackoverflow.com/a/53755378

Hibrix-net · 2023-06-27T08:24:55Z

Same is happenning to me but I had to downgrade until 9.10.4 to make it work as before.

See my comments here: #3020

Connorelsea · 2023-07-05T08:19:04Z

This is still happening for me, downgrading worked. Anybody know why this got closed?

Hibrix-net · 2023-07-05T08:27:55Z

This is still happening for me, downgrading worked. Anybody know why this got closed?

I'm not sure why they kind of ignore it...

vsiao · 2023-07-05T14:02:37Z

This was fixed by d04b294, which is present in v9.18.0, but mistakenly reverted in v9.19.0. Downgrading to v9.18.0 should work for now, while the regression is tracked in #3059.

Hibrix-net · 2023-07-05T18:15:06Z

This was fixed by d04b294, which is present in v9.18.0, but mistakenly reverted in v9.19.0. Downgrading to v9.18.0 should work for now, while the regression is tracked in #3059.

The latest working version for me its the 9.14.0 as @spencermefford said. Anything above spits the same error.
So not solved for me.

FNGR2911 · 2023-07-10T07:01:46Z

Same here, just 9.14.0 is working.. (macOS 13.3.1)

zzeni · 2023-07-11T16:35:07Z

This was fixed by d04b294, which is present in v9.18.0, but mistakenly reverted in v9.19.0. Downgrading to v9.18.0 should work for now, while the regression is tracked in #3059.

Thanks @vsiao , I can confirm that on my MacOS 12.4, versions v9.14.0 and v9.18.0 seem to work fine even without having to set prettierPath in vscode settings (because it defaults to node_modules/prettier).
The versions in-between and v9.19.0 though, are unable to load the prettier module and report the error above.

madhavpcm · 2023-07-21T08:53:56Z

In arch linux, 9.14.0 was spitting out another error, 9.15.0 works.

azat-io · 2023-07-21T11:10:16Z

9.19.0 not works.

["INFO" - 14:09:38] Attempted to load Prettier module from /opt/homebrew/bin/prettier
["ERROR" - 14:09:38] Failed to load module. If you have prettier or plugins referenced in package.json, ensure you have run `npm install`
["ERROR" - 14:09:38] Cannot find Prettier package.json
Error: Cannot find Prettier package.json
	at t.ModuleResolver.loadPrettierVersionFromPackageJson (/Users/azat/.vscode/extensions/esbenp.prettier-vscode-9.19.0/dist/extension.js:1:4058)
	at t.ModuleResolver.getPrettierInstance (/Users/azat/.vscode/extensions/esbenp.prettier-vscode-9.19.0/dist/extension.js:1:5367)
	at t.default.handleActiveTextEditorChanged (/Users/azat/.vscode/extensions/esbenp.prettier-vscode-9.19.0/dist/extension.js:1:10771)
	at i.handleActiveTextEditorChangedSync [as value] (/Users/azat/.vscode/extensions/esbenp.prettier-vscode-9.19.0/dist/extension.js:1:10373)
	at p.w (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:60:1902)
	at p.x (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:60:1972)
	at p.fire (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:60:2188)
	at i.value (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:103:16537)
	at p.w (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:60:1902)
	at p.fire (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:60:2119)
	at e.$kL.acceptDocumentsAndEditorsDelta (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:101:13399)
	at e.$kL.$acceptDocumentsAndEditorsDelta (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:101:11770)
	at t.N (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:111:11199)
	at t.M (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:111:10965)
	at t.H (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:111:10046)
	at t.G (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:111:9122)
	at i.value (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:111:7952)
	at p.w (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:60:1902)
	at p.fire (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:60:2119)
	at f.fire (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:76:13931)
	at i.value (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:127:30341)
	at p.w (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:60:1902)
	at p.fire (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:60:2119)
	at f.fire (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:76:13931)
	at MessagePortMain.<anonymous> (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:127:28621)
	at MessagePortMain.emit (node:events:513:28)
	at MessagePortMain.emit (node:domain:489:12)
	at MessagePortMain._internalPort.emit (node:electron/js2c/utility_init:2:367)

Shimodos · 2023-09-04T21:09:18Z

For Windows users
If you use NVM with different versions of NODE
1.npm i prettier -g
2. in my case, go to the folder with the NODE version C:\Users\admin\AppData\Roaming\nvm\v18.16.0\node_modules
it was installed here prettier
3. copy the prettier folder
4. transfer it to C:\Users\admin\AppData\Roaming\nvm\v18.16.0\node_modules\npm\node_modules
5. Go to VS Code, extension, Prettier : Preettier Path
past C:\Users\admin\AppData\Roaming\nvm\v18.16.0\node_modules\npm\node_modules\prettier
6.reload

https://stackoverflow.com/questions/58866847/in-vs-code-im-getting-this-error-failed-to-load-module-attempted-to-load-pr

Hibrix-net · 2023-09-22T05:51:37Z

Still not solved.

oclero · 2023-10-01T08:48:00Z

Hi! Still not solved, indeed (macOS)

edouard-lopez · 2023-10-03T16:45:01Z

I solved it using this solution and it's work with latest extension version
https://stackoverflow.com/a/77124000/802365

Hibrix-net · 2023-10-04T16:05:15Z

I solved it using this solution and it's work with latest extension version https://stackoverflow.com/a/77124000/802365

I'm in Windows 10. In my settings.json file I have:

"prettier.prettierPath": "C:\Program Files\nodejs\node_modules\prettier",

Do you mean to change that one? I tried with the path suggested in the StackOverflow question but didn't worked.

Could you please tell me where to change this path?

Manty thanks,

github-actions · 2024-01-03T00:17:06Z

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

This was referenced Jun 23, 2023

Fix for Prettier v2 and plugin-tailwindcss problem #3038

Merged

Fix module resolution with prettierPath setting #3042

Merged

ehoogeveen-medweb mentioned this issue Jun 23, 2023

Prettier- TypeError: Cannot read properties of undefined (reading 'uid') #3020

Closed

ntotten closed this as completed in #3042 Jun 26, 2023

whoisarpit mentioned this issue Jul 3, 2023

9.19.0 fails to load from custom prettierPath #3059

Closed

vsiao mentioned this issue Jul 5, 2023

Regression on package.json finding behavior for globally installed prettier with vscode extension #3045

Closed

github-actions bot added the locked Please open a new issue and fill out the template instead of commenting. label Jan 3, 2024

github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

9.16 fails to load from custom prettierPath #3041

9.16 fails to load from custom prettierPath #3041

vsiao commented Jun 23, 2023

tobz1000 commented Jun 23, 2023

spencermefford commented Jun 23, 2023

azat-io commented Jun 23, 2023

vsiao commented Jun 23, 2023

Hibrix-net commented Jun 27, 2023 •

edited

Loading

Connorelsea commented Jul 5, 2023

Hibrix-net commented Jul 5, 2023

vsiao commented Jul 5, 2023

Hibrix-net commented Jul 5, 2023

FNGR2911 commented Jul 10, 2023 •

edited

Loading

zzeni commented Jul 11, 2023

madhavpcm commented Jul 21, 2023

azat-io commented Jul 21, 2023

Shimodos commented Sep 4, 2023 •

edited

Loading

Hibrix-net commented Sep 22, 2023

oclero commented Oct 1, 2023

edouard-lopez commented Oct 3, 2023

Hibrix-net commented Oct 4, 2023

github-actions bot commented Jan 3, 2024

9.16 fails to load from custom prettierPath #3041

9.16 fails to load from custom prettierPath #3041

Comments

vsiao commented Jun 23, 2023

Summary

Steps To Reproduce:

Expected result

Actual result

Additional information

Prettier Log Output

tobz1000 commented Jun 23, 2023

spencermefford commented Jun 23, 2023

azat-io commented Jun 23, 2023

vsiao commented Jun 23, 2023

Hibrix-net commented Jun 27, 2023 • edited Loading

Connorelsea commented Jul 5, 2023

Hibrix-net commented Jul 5, 2023

vsiao commented Jul 5, 2023

Hibrix-net commented Jul 5, 2023

FNGR2911 commented Jul 10, 2023 • edited Loading

zzeni commented Jul 11, 2023

madhavpcm commented Jul 21, 2023

azat-io commented Jul 21, 2023

Shimodos commented Sep 4, 2023 • edited Loading

Hibrix-net commented Sep 22, 2023

oclero commented Oct 1, 2023

edouard-lopez commented Oct 3, 2023

Hibrix-net commented Oct 4, 2023

github-actions bot commented Jan 3, 2024

Hibrix-net commented Jun 27, 2023 •

edited

Loading

FNGR2911 commented Jul 10, 2023 •

edited

Loading

Shimodos commented Sep 4, 2023 •

edited

Loading