Fails to format when "editor.formatOnSaveMode": "modifications" is set

[elektronik2k5]

Hello and thanks for releasing and maintaining this wonderful extension! 🙇‍♂️

Summary

Extension fails to format .component.html files when VSCode's "editor.formatOnSaveMode": "modifications" is set.

Steps To Reproduce:

1. Set "editor.formatOnSaveMode": "modifications" in VSCode settings
2. Try to format using extension (on save or via command)

Expected result

path/to/file.component.html file should be formatted.

Actual result

Status bar shows Extension 'Prettier - Code Formatter' cannot format file path/to/file.component.html and file isn't formatted.

Additional information

Unsetting "editor.formatOnSaveMode": "modifications" in VSCode settings fixes the issue. I suspect that the interop between VSCode's edited ranges and prettier's range is broken. The extension should either implement it or state and fail explicitly if this feature isn't supported.

VS Code Version:

Version: 1.51.1
Commit: e5a624b788d92b8d34d1392e4c4d9789406efe8f
Date: 2020-11-10T23:31:29.624Z
Electron: 9.3.3
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Linux x64 5.9.8-200.fc33.x86_64

Prettier Extension Version:
v5.8.0

OS and version:
Fedora Linux hp 5.9.8-200.fc33.x86_64 #1 SMP Tue Nov 10 21:58:19 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Prettier Log Output

This is strange, cause the output doesn't show an error. Perhaps it is incorrect?

["INFO" - 20:50:53] Using config file at '/[redacted path]/.prettierrc.yaml'
["INFO" - 20:50:53] Prettier Options:
{
  "filepath": "/[redacted path]/src/[redacted path]/file.component.html",
  "parser": "angular",
  "useTabs": false,
  "tabWidth": 2,
  "printWidth": 120,
  "semi": true,
  "singleQuote": true,
  "quoteProps": "as-needed",
  "jsxSingleQuote": false,
  "trailingComma": "all",
  "bracketSpacing": true,
  "jsxBracketSameLine": false,
  "arrowParens": "always",
  "endOfLine": "lf",
  "embeddedLanguageFormatting": "auto"
}
["INFO" - 20:50:53] Formatting completed in 357.514512ms.

[ntotten]

We don't and probably won't (due to how prettier works) support this formatting mode. I'll look to see if we can show a better error.

[elektronik2k5]

Thank you. Do you mind elaborating (or referring to) the reason why they're incompatible?

[ntotten]

Duplicate of #1562

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.