Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to support eslint@v9 #1036

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

phun-ky
Copy link

@phun-ky phun-ky commented Oct 14, 2024

  • chore!: Upgrade to , and update eslint setup

Warning

This PR is not complete, but some of the heavy lifting to prepare for v9 is done. Feel free to continue!

It is including, but not limited to:

  • New set of eslint rules
  • New set of prettier rules
  • Approaching a TS setup instead of vanilla
  • Replacing (not complete) jest with vitest
  • Replacing babel with vite (not started)

Closes: #947 #1015

Copy link

changeset-bot bot commented Oct 14, 2024

⚠️ No Changeset found

Latest commit: 7198060

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Stale pull request

@Mettbrot
Copy link

@phun-ky can you take this up again? What is missing to get eslint upgraded?

@phun-ky
Copy link
Author

phun-ky commented Jan 29, 2025

@Mettbrot I can take a look at it tomorrow and see if there's anything I can do more. I have some spare time moving forwards apaprently

@Mettbrot
Copy link

Wow, cool Thanks! We’d need to find a maintainer of this, it seems pretty silent around the PRs #1107

@JounQin JounQin reopened this Jan 30, 2025
@phun-ky
Copy link
Author

phun-ky commented Jan 30, 2025

@JounQin first blocker: prettier-eslint-cli uses "eslint": "^8.51.0", as a dep, and also "@prettier/eslint": "npm:prettier-eslint@^16.1.0" as a dep, and that dep uses "eslint": "^8.7.0", as a dep. I have updated to latest, but none of them can be used until they are fixed.

@Mettbrot
Copy link

They live in this very repository too, right? Can we update them too and release them in one go?

@JounQin
Copy link
Member

JounQin commented Jan 31, 2025

overrides for npm/pnpm and resolutions for yarn could be used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: support flat config with FlatESLint
3 participants