-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using ESLint 5's ConfigFile.load
, which is gone in ESLint 6.
#303
Labels
Comments
This was referenced Sep 14, 2020
Stale issue |
Go away stale-bot, there’s no sign this issue has been fixed. 🙂 |
(I believe the issue still hasn't been fixed.) |
It is not. 😕 |
Fixed in #431! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
prettier-eslint-cli
can't currently use ESLint 6, and it would be great to fix that (see #304).Ever since #91 was merged,
pretter-eslint-cli
has been using a util functionConfigFile.load
that doesn't exist in ESLint 6; it was removed in eslint/eslint#11546 (merged in eslint/eslint@6ae21a4; released in v6.0.0-alpha.1).To see the problem in action, get
prettier-eslint-cli
to use ESLint 6 (e.g., 6.8.0). One way to do this is to put lines like the following in thepackage.json
of a project that usesprettier-eslint-cli
:Run
yarn
/npm install
, then run the CLI, and see error output containing this:If it's important that we keep invoking ESLint's code for loading an ESLint config, it would be great to try to use something that's unambiguously part of ESLint's public API.
If it's not important, it might be good to stop doing so. In particular, I think the current behavior doesn't align with this bit of basic summary in the README for what
prettier-eslint-cli
does:The text was updated successfully, but these errors were encountered: