PHP8 - multiple attributes in same #[] bracket notation with \ in name fails, e.g. Assert\NotBlank in certain combination.

[AndreasA]

Not sure if it is actually the plugin or the php parser but the code snippet fails to be formatted and actually fails with an exception.

For this issue to occur some specific requirements have to be met:

• if \ is used for the argument, e.g. fully qualified class name.
• At least two attributes are used in the same #[] bracket.
• At least two of them use \.
• At least two attributes use two arguments or more.

Prettier 2.6.2

PHP Plugin 0.18.4

Options:

{
  "printWidth": 80,
  "tabWidth": 4,
  "useTabs": false,
  "singleQuote": true,
  "phpVersion": "8.1",
  "trailingCommaPHP": true,
  "braceStyle": "psr-2",
  "requirePragma": false,
  "insertPragma": false
}

Input:

<?php declare(strict_types=1);

namespace Foo;

use Symfony\Component\Validator\Constraints as Assert;

class ValueModel
{
    #[
        Assert\NotBlank(allowNull: false, groups: ['foo']),
        Assert\Length(max: 255, groups: ['foo']),
    ]
    public ?string $value = null;
}

Output:

Parse Error : syntax error, unexpected '\' (T_NS_SEPARATOR), expecting ']' on line 11

   9 |     #[
  10 |         Assert\NotBlank(allowNull: false, groups: ['foo']),
> 11 |         Assert\Length(max: 255, groups: ['foo']),
     |              ^
  12 |     ]
  13 |     public ?string $value = null;
  14 | }

Expected behavior:
Not to fail.

Playground example

[AndreasA]

As mentioned this might actually be due to issues with the php-parser: glayzzle/php-parser#486

[AndreasA]

php-parser just released a new version https://www.npmjs.com/package/php-parser/v/3.1.0-beta.6 which fixes various attribute issues - which should include this one.

[czosel]

@AndreasA correct - I wanted to bump the parser dependency here already, but ran into a regression: glayzzle/php-parser#934
I hope that we can get it fixed soon, then shipping this fix (and others) should be simple.

[czosel]

Fixed in v0.18.5 🎉