Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added comment signature to PR review comments #19

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Added comment signature to PR review comments #19

merged 2 commits into from
Nov 22, 2024

Conversation

bstanga
Copy link
Contributor

@bstanga bstanga commented Nov 22, 2024

No description provided.

Copy link

github-actions bot commented Nov 22, 2024

PR Summary

Enhanced the comment handling functionality by adding a signature to all PR review comments. Introduced a new buildComment function that appends a predefined signature to comment content, ensuring consistent identification of bot-generated comments across the codebase.

Changes

File Summary
dist/index.js Generated updated JavaScript bundle reflecting the changes in the TypeScript source files.
src/comments.ts Added new buildComment function that appends the COMMENT_SIGNATURE to comment content, standardizing the format of bot-generated comments.
src/pull_request.ts Updated PR review submission to use buildComment function when creating line comments and review comments, ensuring all comments include the signature.
src/pull_request_comment.ts Integrated buildComment function in PR comment handling to append signature to response comments. Updated imports to include the new function.

autogenerated by presubmit.ai

@github-actions github-actions bot changed the title Dev @presubmit Added comment signature to PR review comments Nov 22, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 Pull request needs attention.

Review Summary

Commits Considered (2)
  • 2d03dae: update binary
  • b5a3d8a: include comment signature in PR review comments
Files Processed (4)
  • dist/index.js (0 hunks)
  • src/comments.ts (1 hunk)
  • src/pull_request.ts (3 hunks)
  • src/pull_request_comment.ts (2 hunks)
Actionable Comments (1)
  • src/comments.ts [99-101]

    possible issue: "Missing input validation for comment parameter"

Skipped Comments (1)
  • src/comments.ts [99-101]

    best practice: "String concatenation could lead to inconsistent line endings"

src/comments.ts Show resolved Hide resolved
@bstanga bstanga merged commit 363633b into main Nov 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant