-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for expanding environment variables in configuration files. #378
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of automation failures.
config_file = os.path.join(DIR, 'resources', 'environment_variable.properties') | ||
conf = config.get_conf_from_properties_file(config_file) | ||
self.assertTrue(environment_variables.called) | ||
self.assertEqual({'a': 'environment_variable_value'}, conf) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we have an real test that is using actual environment variable, to see the configuration with expanded environment variables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late reply. I will work on this as well as automation failures.
@rootG Please ping once you done with your changes. |
this PR seems quite old. Is anyone going to revive it? @kokosing |
Closes #329
Added support for expanding environment variables in configuration files.
For example:
Given an example node.properties files
application can now resolve variable defined by
${ENV}
from environment variables.${variableName}
or$variableName
. In addition to this, on Windows,%variableName%
definition is supported as well.