You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 23, 2018. It is now read-only.
It uses sleep 0.01 for waiting for the command to finish, which is very CPU heavy and definitively not the right way (you can do the waiting with IO.pipe, as shown in this blog post)
It captures stdout and stderr both in the same string, which is unusable when we actually care which is which
Most-importantly, there is already an implementation of this gem in the Ruby standard library, called open3. The Open3.catpure3 does everything that this gem does, but better and with automatic Windows support and similar. It doesn't however work on JRuby, because they didn't implement it, but they're fixing it.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This gem doesn't have a good implementation:
sleep 0.01
for waiting for the command to finish, which is very CPU heavy and definitively not the right way (you can do the waiting withIO.pipe
, as shown in this blog post)Most-importantly, there is already an implementation of this gem in the Ruby standard library, called
open3
. TheOpen3.catpure3
does everything that this gem does, but better and with automatic Windows support and similar. It doesn't however work on JRuby, because they didn't implement it, but they're fixing it.The text was updated successfully, but these errors were encountered: