Skip to content
This repository has been archived by the owner on Nov 23, 2018. It is now read-only.

Deprecate this gem #21

Open
janko opened this issue Oct 26, 2014 · 0 comments
Open

Deprecate this gem #21

janko opened this issue Oct 26, 2014 · 0 comments

Comments

@janko
Copy link

janko commented Oct 26, 2014

This gem doesn't have a good implementation:

  • It uses sleep 0.01 for waiting for the command to finish, which is very CPU heavy and definitively not the right way (you can do the waiting with IO.pipe, as shown in this blog post)
  • It captures stdout and stderr both in the same string, which is unusable when we actually care which is which

Most-importantly, there is already an implementation of this gem in the Ruby standard library, called open3. The Open3.catpure3 does everything that this gem does, but better and with automatic Windows support and similar. It doesn't however work on JRuby, because they didn't implement it, but they're fixing it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant