Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make goose annotations case-insensitive #678

Closed
mfridman opened this issue Dec 24, 2023 · 0 comments · Fixed by #704
Closed

Make goose annotations case-insensitive #678

mfridman opened this issue Dec 24, 2023 · 0 comments · Fixed by #704

Comments

@mfridman
Copy link
Collaborator

mfridman commented Dec 24, 2023

There are currently 7 goose annotations that may be found in a .SQL file. These annotations define how goose behaves when it reads a .SQL file (outdated post, but should give you an idea of how/why to use these annotations).

Over the years as different folks worked on the project, we've mixed uppercase and pascal case. For consistency, we should make these (and future) annotations case-insensitive.

While we do this, we should also add validation to ensure if we come across -- +goose [annotation] that the annotation is known to goose and otherwise error.

+goose Up
+goose Down
+goose StatementBegin
+goose StatementEnd
+goose NO
+goose ENVSUB
+goose ENVSUB
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant