Timeout Flag

[smantic]

One of the features I personally feel that the goose cli is missing is a --timeout flag for migrations.

This would require migrations finish within an allotted amount of time or else rollback back the migration.

I took a precursory look at the code base and with the new context aware functions this might be pretty straight forward to implement by putting a timeout on the context if --timeout is specified, and then passing that into sql.DB.BeginTx.
I think migrations with multiple transactions may cause a bit more complexity but still doable.

Thoughts?

[mfridman]

Yep, sounds like a great idea since we can propagate a ctx down.

We can also take this a bit further (although probably captured in a separate issue/PR) by propagating a cancellation by leveraging https://pkg.go.dev/os/signal#NotifyContext in the CLI.

[mfridman]

Not sure if you were looking to contribute, but I can go ahead and implement a timeout and propagate a cancellation.

[smantic]

@mfridman I can whip up a PR, let me know if you would like me to.

[mfridman]

Sure thing, PRs always appreciated.